GUI: Reordering repos is weird #1409
Assignees
Labels
Bug
Something is not working as intended
Comments
pjf
added a commit
that referenced
this issue
Sep 1, 2015
* Postremus/#1409_2: reordering of repos isn't weird anymore fixes #1409
pjf
added a commit
that referenced
this issue
Sep 10, 2015
* origin/master: (31 commits) Simply colum sorting to use methods rather than closures GUI: Partially documented the process of updating the mod list Release v1.14.1 (Eris) Fix a castexception when installing metapackage The install logic still used a KeyValuePair<GuiMod, GuiModChangeTyp> while everything else uses ModChange object's now reordering of repos isn't weird anymore fixes #1409 Add missing PR on CHANGELOG for netkan.exe --version GUI: Extra documentation on modlist reasons. Made the reasons more uniform in the changeset Documented CreateSortedModList, made it *hopefully" forward compatible Use the name in the reasons, not the identifier The SelectionReason's should be human friendly. A identifier isn't. fixed tmp test Sort the changeset list by action an their reason the actions are sorted in the order Remove, Action and Install the reasons are only sorted for install, based on if a to be installed mod depends on another to be installed mod Renamed the description column to "Reason for action Fill the description column with the selection reasons Or if it is an update, just say to which version we are going to Fixed a typo in the Depends reason Changeset is now using one ModChange instance per change This ModChange class also contains a Selectionreason which is used to describe why a mod was select for a change in a human friendly way made the selectionreason public Added missing pr number Implemented a int sorter Moved the creation of the 3 different sorter kinds into different methods for: string based, integer based and checkbox based fixes #1419 protect the @thumbs folder as well ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We seem to order our repos by giving them a number (I don't know why) and having the GUI increase/decrease this number when we hit the up/down buttons in the GUI settings page. However rather than making the number one bigger or smaller than the largest or smallest number, we seem to just increment/decrement it, meaning we can get number conflicts and repos seem to jump around in ordering.
Steps to reproduce: Add at least three repos. Try moving the top one down, or the bottom one up a few times. Observe that it will sometimes "jump" an extra space.
What we should be doing: Not have them jump around. I'm not sure why the numbers are there at all, since lists are ordered in nature anyway.
Discovered in testing of #1393.
The text was updated successfully, but these errors were encountered: