Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI: Download sizes should be sorted as numbers, not strings. #1419

Closed
pjf opened this issue Aug 25, 2015 · 7 comments · Fixed by #1420
Closed

GUI: Download sizes should be sorted as numbers, not strings. #1419

pjf opened this issue Aug 25, 2015 · 7 comments · Fixed by #1420
Assignees
@Postremus
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI

Comments

@pjf
Copy link
Member

pjf commented Aug 25, 2015

Steps to reproduce:

  1. Open the GUI
  2. Sort by download size.
@mheguy mheguy added Bug Something is not working as intended GUI Issues affecting the interactive GUI ★☆☆ labels Aug 25, 2015
@Postremus
Copy link
Contributor

That is The default sorting, done in mainmodlist.cs

----- Ursprüngliche Nachricht -----
Von: "Paul Fenwick" notifications@github.com
Gesendet: ‎25.‎08.‎2015 08:36
An: "KSP-CKAN/CKAN" CKAN@noreply.github.com
Betreff: [CKAN] GUI: Download sizes should be sorted as numbers, not strings.(#1419)

Steps to reproduce:
Open the GUI
Sort by download size.
—
Reply to this email directly or view it on GitHub.

@Postremus Postremus mentioned this issue Aug 25, 2015
Merged
@Postremus Postremus self-assigned this Aug 25, 2015
@Postremus Postremus mentioned this issue Aug 29, 2015
Closed
@jenyaza01
Copy link

Thaks.
And what about completely disable sorting by Installed version and Latest version - it makes no sense?

@Postremus
Copy link
Contributor

What exactly do you mean?

@jenyaza01
Copy link

Disable sorting in these columns
2

@Postremus
Copy link
Contributor

Please create a new issue for this. :)

@jenyaza01
Copy link

Really? Okay, that does not stop anyone.
And it is not enough for the whole issue, IMHO. Only if you need...

@Postremus
Copy link
Contributor

@jenyaza01 yup, one issue for every request is normal.

----- Ursprüngliche Nachricht -----
Von: "jenyaza01" notifications@github.com
Gesendet: ‎29.‎08.‎2015 18:54
An: "KSP-CKAN/CKAN" CKAN@noreply.github.com
Cc: "Martin Panzer" postremus1996@googlemail.com
Betreff: Re: [CKAN] GUI: Download sizes should be sorted as numbers, notstrings. (#1419)

Really? Okay, that does not stop anyone.
And it is not enough for the whole issue, IMHO.
—
Reply to this email directly or view it on GitHub.

@pjf pjf closed this as completed in #1420 Sep 10, 2015
@pjf pjf removed the pull request label Sep 10, 2015
pjf added a commit that referenced this issue Sep 10, 2015
@pjf
Merge #1420: Numerical columns can now be sorted as numbers.
07157d6 
* 1420_adjust:
  Simply colum sorting to use methods rather than closures
  Implemented a int sorter Moved the creation of the 3 different sorter kinds into different methods for: string based, integer based and checkbox based fixes #1419
pjf added a commit that referenced this issue Sep 10, 2015
@pjf
Merge remote-tracking branch 'origin/master' into adjust_1410
a03b5c8 
* origin/master: (31 commits)
  Simply colum sorting to use methods rather than closures
  GUI: Partially documented the process of updating the mod list
  Release v1.14.1 (Eris)
  Fix a castexception when installing metapackage The install logic still  used a KeyValuePair<GuiMod, GuiModChangeTyp> while everything else uses ModChange object's now
  reordering of repos isn't weird anymore fixes #1409
  Add missing PR on CHANGELOG for netkan.exe --version
  GUI: Extra documentation on modlist reasons.
  Made the reasons more uniform in the changeset
  Documented CreateSortedModList, made it *hopefully" forward compatible
  Use the name in the reasons, not the identifier The SelectionReason's should be human friendly. A identifier isn't.
  fixed tmp test
  Sort the changeset list by action an their reason the actions are sorted in the order Remove, Action and Install the reasons are only sorted for install, based on if a to be installed mod depends on another to be installed mod
  Renamed the description column to "Reason for action
  Fill the description column with the selection reasons Or if it is an update, just say to which version we are going to
  Fixed a typo in the Depends reason
  Changeset is now using one ModChange instance per change This ModChange class also contains a Selectionreason which is used to describe why a mod was select for a change in a human friendly way
  made the selectionreason public
  Added missing pr number
  Implemented a int sorter Moved the creation of the 3 different sorter kinds into different methods for: string based, integer based and checkbox based fixes #1419
  protect the @thumbs folder as well
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Postremus Postremus

Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GUI: Numerical columns can be sorted numerically
4 participants
@pjf @Postremus @mheguy @jenyaza01