Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mono 6.6 and more recent versions of everything else #2964

Merged
merged 3 commits into from
Jan 20, 2020

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jan 16, 2020

Problem

Recent net-core builds have been failing.

Error: The assembly name is invalid.

Today my Ubuntu upgraded from Mono 6.6 to Mono 6.8, and suddenly I was affected locally by the same problem for all builds.

Cause

See cake-build/cake#2695, it looks like a check was added to Mono in mono/mono#16446 to reject full pathnames for assemblies, but unfortunately parts of Microsoft.CodeAnalysis (closed source?) appear to pass full pathnames, which breaks Cake. This will probably need to be fixed on the Mono side, but I don't yet have enough information for a useful report.

The net-core builds were set to mono: latest instead of a specific version like everything else, so when this (apparently) broken version shipped we started using it immediately.

Changes

To fix the error:

  • Now our net-core builds use Mono 6.6 instead of latest

General upkeep:

  • Now we build on bionic instead of xenial
  • Versions of Mono older than 5.16 are dropped, 6.0 through 6.6 are added, and we'll ship the one from 6.6
  • NuGet and Cake and Cake.SemVer versions are updated
  • net-core version is updated from 2.1 to 3.1

@HebaruSan HebaruSan added Bug Something is not working as intended Pull request Build Issues affecting the build system Linux Issues specific for Linux Mono Issues specific for Mono Cake Issues affecting Cake labels Jan 16, 2020
@DasSkelett
Copy link
Member

I guess you tested on Linux? I currently don't have access to my Linux machine, but on Windows it works fine for me after updating the VS build tools (had no NetCore 3.1 installed yet).

@HebaruSan

This comment has been minimized.

@DasSkelett

This comment has been minimized.

@HebaruSan

This comment has been minimized.

@HebaruSan

This comment has been minimized.

@DasSkelett

This comment has been minimized.

@HebaruSan
Copy link
Member Author

OK, I managed to restore a Mono 6.6 install, and I'm able to compile and run CKAN.

Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I already wrote, works on W10, can't test on Linux as I'm on the road currently.

@HebaruSan
Copy link
Member Author

I'll give @Olympic1 another few days to weigh in, in case I've missed something important about these versions.

@politas
Copy link
Member

politas commented Jan 17, 2020

I'm still away from home. Will test on Manjaro when I get home.

Copy link
Member

@Olympic1 Olympic1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully build on Windows

@HebaruSan HebaruSan merged commit 6e20d15 into KSP-CKAN:master Jan 20, 2020
@HebaruSan HebaruSan deleted the update-build-deps branch January 20, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Build Issues affecting the build system Cake Issues affecting Cake Linux Issues specific for Linux Mono Issues specific for Mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants