Make Mono 6 builds work on Windows #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
|
Got a graphical docker:5.20 container running with this: xhost +si:localuser:root
docker run -e DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix -v `pwd`:/build -it mono:5.20 /usr/bin/mono /build/ckan.exeTrying with a master ckan.exe it throws the Mono5 error from #2976 as expected, a build from your branch does indeed start successfully! 🎉 |
|
Wonder whether Visual Studio will automatically add them back in when somebody edits the localizations with it. I guess we'll find out when somebody does that, just have to pay attention that it doesn't sneak in. |
Mono 5 throws a bunch of other errors in the background, but they're all non-fatal and might be due to running in a Docker container. |
DasSkelett
approved these changes
Dec 1, 2020
It would be great to make a Test for this somehow. Any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Before #2964, we built releases on Mono 5.16, then that PR changed it to Mono 6.6. This broke things (see below), so as
a workaround, #2976 changed it back to Mono 5.20 in a panic. Here we attempt to address the root cause.
Problem
When we build on Mono 6, running the GUI on Windows throws an exception at startup:
Mono 5 also freaks out, in a similar but slightly different way. It seems the same problem causes a null reference exception instead of the above.
Cause
Clearly there's something involving
CalendarIdthat Windows doesn't like. The.resxfiles are compiled to.resourcesfiles in_build/out/CKAN-GUI/Debug, and if we inspect one of these files in a Mono 6 build, we indeed see instances ofCalendarId:Looking above, these seem to be within an instance of a
System.Globalization.CultureInfoobject, and our.resxfile contains exactly one of those, in the$this.Languageproperty. The same file built on Windows shows no references toCalendarIdat all; so Mono and .NET disagree on precisely howCultureInfoshould be (de)serialized, which causes problems trying to use data from one platform on the other.$this.Languagesets theControl.LanguageorForm.Languageproperty, which is used by Visual Studio to control what locale is being edited in its form designer. This property has no role at run-time 🤦.Changes
Now our
.resxfiles no longer contain$this.Language, which makes our Mono 6 builds run on Windows and Mono 5.To celebrate, we now build releases on
mono:latest.