Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Even if you have a few rows to avoid the crash, only updates with rows visible in the current filter will be marked.
Cause
ModGrid.Rows
is empty when this line tries to access its first element:CKAN/GUI/Controls/ManageMods.cs
Lines 404 to 405 in cfb5881
And the updates are marked by looping over
ModGrid.Rows
, which only includes visible rows.Changes
ModGrid.Rows
isn't empty before trying to access a rowmainModList.full_list_of_mod_rows.Values
instead of just the visible rowsFixes #3078.