Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on marking all updates #3079

Merged
merged 1 commit into from
Jun 15, 2020
Merged

Fix crash on marking all updates #3079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 24 additions & 25 deletions GUI/Controls/ManageMods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,31 +380,25 @@ public void Filter(GUIModFilter filter, ModuleTag tag = null, ModuleLabel label

public void MarkAllUpdates()
{
foreach (DataGridViewRow row in ModGrid.Rows)
foreach (DataGridViewRow row in mainModList.full_list_of_mod_rows.Values)
{
var mod = (GUIMod)row.Tag;
if (mod.HasUpdate)
var mod = row.Tag as GUIMod;
if (mod?.HasUpdate ?? false)
{
MarkModForUpdate(mod.Identifier, true);
mod.SetUpgradeChecked(row, UpdateCol, true);
}
}

// only sort by Update column if checkbox in settings checked
if (Main.Instance.configuration.AutoSortByUpdate)
{
// set new sort column
var new_sort_column = ModGrid.Columns[UpdateCol.Index];
var current_sort_column = ModGrid.Columns[Main.Instance.configuration.SortByColumnIndex];

// Reset the glyph.
current_sort_column.HeaderCell.SortGlyphDirection = SortOrder.None;
Main.Instance.configuration.SortByColumnIndex = new_sort_column.Index;
UpdateFilters();

SetSortColumn(UpdateCol, false);
// Select the top row and scroll the list to it.
ModGrid.CurrentCell = ModGrid.Rows[0].Cells[SelectableColumnIndex()];
if (ModGrid.Rows.Count > 0)
{
ModGrid.CurrentCell = ModGrid.Rows[0].Cells[SelectableColumnIndex()];
}
}

ModGrid.Refresh();
}

Expand Down Expand Up @@ -465,6 +459,20 @@ private void ModList_SelectedIndexChanged(object sender, EventArgs e)
}
}

private void SetSortColumn(DataGridViewColumn col, bool? descending = null)
{
var prevSortCol = ModGrid.Columns[Main.Instance.configuration.SortByColumnIndex];

// Reverse the sort order if the current sorting column is clicked again.
Main.Instance.configuration.SortDescending = descending
?? col == prevSortCol && !Main.Instance.configuration.SortDescending;

// Reset the glyph.
prevSortCol.HeaderCell.SortGlyphDirection = SortOrder.None;
Main.Instance.configuration.SortByColumnIndex = col.Index;
UpdateFilters();
}

/// <summary>
/// Called when there's a click on the ModGrid header row.
/// Handles sorting and the header right click context menu.
Expand All @@ -474,16 +482,7 @@ private void ModList_HeaderMouseClick(object sender, DataGridViewCellMouseEventA
// Left click -> sort by new column / change sorting direction.
if (e.Button == MouseButtons.Left)
{
var new_sort_column = ModGrid.Columns [e.ColumnIndex];
var current_sort_column = ModGrid.Columns [Main.Instance.configuration.SortByColumnIndex];

// Reverse the sort order if the current sorting column is clicked again.
Main.Instance.configuration.SortDescending = new_sort_column == current_sort_column && !Main.Instance.configuration.SortDescending;

// Reset the glyph.
current_sort_column.HeaderCell.SortGlyphDirection = SortOrder.None;
Main.Instance.configuration.SortByColumnIndex = new_sort_column.Index;
UpdateFilters();
SetSortColumn(ModGrid.Columns[e.ColumnIndex]);
}
// Right click -> Bring up context menu to change visibility of columns.
else if (e.Button == MouseButtons.Right)
Expand Down