Mark conflicts in initial recommendations #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
DasSkelett
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you try to install RP-0 from before KSP-RO/RP-1#1303 and KSP-CKAN/CKAN-meta#2099, the install will fail on the conflict between RealAntennas and RemoteTech. But this happens in the install flow; the recommendations screen seems to think everything is fine, when it should be catching this conflict.
Cause
The recommendations view was only checking for conflicts after the user clicked, presumably on the assumption that mods won't recommend conflicting modules. But they have!
Changes
Now we check for conflicts right after we finish loading the recommendations. For those old RP-0 revisions, the rows are red right at the start.