Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend TestLite, fix antenna conflict #1303

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

HebaruSan
Copy link
Contributor

@HebaruSan HebaruSan commented Jul 2, 2020

Motivation

The RP-0 wiki mod recommendations page mentions TestLite as a manual install on these pages:

As of KSP-CKAN/NetKAN#8006, TestLite is now in CKAN (only updated for KSP 1.6.1 through 1.7.3, but the author is planning new releases).

Problem

The current RP-0 metanetkan recommends both RealAntennas and RemoteTech, which conflict with one another. This causes the install to fail if the user doesn't make any manual changes.

Changes

  • spec_version updated to v1.26 to allow use of any_of relationship (this just means the user's CKAN can't be horribly outdated)
  • RealAntennas and RemoteTech recommendations placed in an any_of block so they won't be checked by default and the user can choose which to use
  • TestLite is added to the recommendations, inside of an any_of block with TestFlight so CKAN doesn't try to install both by default (the user can pick which one they want, and if they try to pick both it'll highlight them red)

Tagging @siimav yadda yadda.

@siimav
Copy link
Contributor

siimav commented Jul 2, 2020

Thanks! Those are some really sweet changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants