Init Curl at netkan.exe and ckan.exe startup #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
HebaruSan
changed the title
|
Ok, this has bugged me for 5 years! Thanks for fixing it!!! 🎉 |
This was referenced Jul 10, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
Curl.CreateEasyrequires thatCurl.Init()be called; if it hasn't been, it will be at that point. SupposedlyCurl.Init()isn't thread-safe, soCreateEasywill print a warning about this since it can't guarantee that it's not being executed in some complicated threading scenario.Netkan falls afoul of this by not calling
Curl.Init()till it's needed.Changes
Now we init Curl at netkan and ckan startup, which isn't in a complicated threading scenario, so the message won't appear anymore.
Fixes #1441.