Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://ci.ksp-ckan.space/job/NetKAN/9883/console
The command that's failing is
mono ckan.exe version
.Cause
In #3107 we started calling
Curl.Init()
unconditionally at the start of ckan.exe and netkan.exe to suppress the "non-threadsafe init" message.Curl.Init()
throws that exception if libcurl isn't installed.Background
https://github.com/KSP-CKAN/CKAN/wiki/libcurl
We just made it required again. That's no good.
Changes
Now
Curl.Init()
doesn't care if the DLL isn't found.