Tell user if instance addition fails #3332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a user tries to add a game instance for which they lack filesystem write privileges, it fails silently, and an exception appears in the terminal:
Most users don't look at the terminal, so this is confusing.
Cause
We try to create the
<KSP>/CKAN
folder, which fails, and we don't catch the exception.Changes
Now if an exception is thrown when we try to add an instance, we display the exception's
Message
in an error popup. This way the user should have some clue why it failed.Also fixed two minor compiler warnings to do with
TarInputStream
wanting an encoding parameter and acatch
block not using a parameter.Fixes #3330.