Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell user if instance addition fails #3332

Merged
merged 1 commit into from
Mar 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Net/Repo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ private static List<CkanModule> UpdateRegistryFromTarGz(string path, out SortedD
using (GZipInputStream gzipStream = new GZipInputStream(inputStream))
{
// Create a handle for the tar stream.
using (TarInputStream tarStream = new TarInputStream(gzipStream))
using (TarInputStream tarStream = new TarInputStream(gzipStream, Encoding.UTF8))
{
TarEntry entry;
while ((entry = tarStream.GetNextEntry()) != null)
Expand Down
5 changes: 4 additions & 1 deletion GUI/Dialogs/ManageGameInstancesDialog.cs
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ private void AddToCKANMenuItem_Click(object sender, EventArgs e)
{
_user.RaiseError(Properties.Resources.ManageGameInstancesNotValid,
new object[] { k.path });
return;
}
catch (Exception exc)
{
_user.RaiseError(exc.Message);
}
}

Expand Down
2 changes: 1 addition & 1 deletion Netkan/Validators/VrefValidator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public void Validate(Metadata metadata)
// This means the install stanzas don't match any files.
// That's not our problem; someone else will report it.
}
catch (Kraken k)
catch (Kraken)
{
// If FindInternalAvc throws anything else, then there's a version file with a syntax error.
// This shouldn't cause the inflation to fail, but it does deprive us of the path.
Expand Down