Global install filters

[HebaruSan]

Motivation

As of some recent API changes, users might install somewhat older mods that would work except that they bundle MiniAVC.dll, which crashes the game on startup. Even before the crashes, MiniAVC was annoying and unnecessary thanks to CKAN's own compatibility checking. It would be nice to prevent MiniAVC from being installed.

NOTE: The crash was specific to KSP 1.12.2, and was fixed in 1.12.3.

Similarly, some power users may wish to customize the details of how certain mods are installed, often a cfg file that patches how two or more mods interact. Currently they can only do this by deleting them manually after installation, which means they will re-appear after upgrades.

Changes

A new menu option under Settings opens a window with text boxes for installation filters that apply to all mods:

If you add a string to either of these boxes, then CKAN will not install any file where that string is contained in the full relative path. The top box applies to all game instances, and the bottom box applies only to the current instance. The target audience for this window is power users who are comfortable typing paths, but an Add MiniAVC button is available so typical users can more easily avoid installing MiniAVC.

Cmdline now has a ckan filter subcommand to manage these lists, and ConsoleUI has a new screen that works like the one in GUI.

Fixes #2490.
Fixes #3129.

[vinix38]

Hi, here is the usual French translation :)

installfiltersdialog

<data name="GlobalFiltersGroupBox.Text" xml:space="preserve"><value>Filtres Globaux</value></data>
<data name="InstanceFiltersGroupBox.Text" xml:space="preserve"><value>Filtres de l'Instance</value></data>
<data name="AddMiniAVCButton.Text" xml:space="preserve"><value>Ajouter MiniAVC</value></data>
<data name="$this.Text" xml:space="preserve"><value>Installer des Filtres</value></data>

main

<data name="installFiltersToolStripMenuItem.Text" xml:space="preserve"><value>Installation de filtres</value></data>

[DasSkelett]

I was thinking whether a simple .Contains() check might be too broad and filter out files that people didn't want to, but since I can't think of a case where this could happen I guess it's okay. And every attempt to change this would make it a lot more complex and less accessible (e.g. if we made it behave like shell globs).

[HebaruSan]

Yeah, if a filter is too broad, the user can add more characters to match only the right file(s), as in changing MiniAVC to MiniAVC.dll. If it's not broad enough, they can do the reverse, or add more filters. I think .Contains() gives us a pretty good level of flexibility here.

[DasSkelett]

Should we re-scan the already installed files after the user changes the filters? I can imagine that some might expect MiniAVC.dll to disappear after they add it to a filter, but it seems like doing that could get messy (i.e., what about installing files that were filtered out previously when a filter is removed?).

I would keep it as is, people can still reinstall the mod they want. We could put a sentence in the "Install filters" window like

Changes to the install filters only take effect on future mod installations, already installed files are unaffected

[HebaruSan]

Coming up in a few moments:

[HebaruSan]

OK, should be all set now. ✔️

[vinix38]

Just added a few bits that I had missed during translation

[DasSkelett]

All three UI are fine, and it works very well. Thanks!