Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-sort module properties after merging #3957

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

HebaruSan
Copy link
Member

Problem

After merging KSP-CKAN/NetKAN#9882, I noticed ksp_version was appearing out of its normal ordering:

image

Cause

The GitHub module has no versioning info at all, whereas the one from SpaceDock has a game version, and otherwise they're identical, so the merge code is appending just that one property from the SpaceDock module onto the GitHub module after it's sorted.

Changes

Now the merge logic reapplies sorting, so multi-host .ckans will have the same property ordering as single-host ones.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Netkan Issues affecting the netkan data labels Dec 15, 2023
@HebaruSan HebaruSan requested a review from techman83 December 15, 2023 22:30
@HebaruSan HebaruSan merged commit d43a2ac into KSP-CKAN:master Dec 15, 2023
8 checks passed
@HebaruSan HebaruSan deleted the fix/merge-prop-sort branch December 15, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant