Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kerbalism Side Patches from SpaceDock #9882

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Conversation

netkan-bot
Copy link
Member

This pull request was automatically generated by SpaceDock on behalf of JadeOfMaar, to add Kerbalism Side Patches to CKAN.

Please direct questions about this pull request to JadeOfMaar.

Mod details

Key Value
Name Kerbalism Side Patches
Authors JadeOfMaar
Abstract Quick QoL configs for Kerbalism players
License MIT
Size 3.47 KiB
Homepage <>
Source code https://github.com/JadeOfMaar/KerbalismSidePatches

Description

  • Introduces proper reliability buff to all ion engines and to nuke engines via opt-in configs

This is an automated commit on behalf of JadeOfMaar
@HebaruSan
Copy link
Member

HebaruSan commented Dec 15, 2023

Hmm, ksp_version is appearing out of its normal ordering, which makes me nervous:

image

It may be that the module-merging pass can have non-deterministic output. However, all the other properties are as expected, so 🤞? Fortunately, if there's an issue here, fixing it won't require a new client release...

OK, I think that's because the GitHub module has no versioning info at all, whereas the one from SpaceDock has a game version. So the inflator is appending just that one property from the SpaceDock module onto the GitHub module after it's sorted. I suppose the merge logic should reapply sorting; something to return to later, but no harm in leaving it like this for now because the ordering will still be stable from one inflation to the next.

@HebaruSan HebaruSan merged commit b1ca2bc into master Dec 15, 2023
1 check passed
@HebaruSan HebaruSan deleted the add/KerbalismSidePatches branch December 15, 2023 19:00
@JonnyOThan
Copy link
Contributor

Does this mod require kerbalism-default or is it viable with any kerbalism config?

@HebaruSan
Copy link
Member

No idea. @JadeOfMaar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants