Refactor + Modernise Actions

[techman83]

This is a complete refactor and overhaul of our actions, and either updating or changing any outdated actions we have used within our workflows.

Changes

Building

The build workflow is now a self contained, and runs on master or via 'workflow_call'. Making a single source of truth for building CKAN/NetKAN.

Note: The build on master is intentional, I expect there we can do a small amount of work to enable dotnet caching. For a cache to be available on branches, it must have been previously built on the default branch.

Testing

There is a new test file that calls build first. It is unnecessary to build inside the Mono containers, as we still use dotnet to build. This however ensures we are keeping the same validation as before. We can likely look to considering if this is still required.

Deploy

Deployment now calls build first, followed by versioning, and then the rest of the steps.

• All S3 actions now use the official AWS tools
• Only RPM needs an extra tool outside what comes by default

Example here: https://github.com/KSP-CKAN/CKAN/actions/runs/8948785797
Example with containers (fails as I omitted auth): https://github.com/KSP-CKAN/CKAN/actions/runs/8948756697/job/24582270638

Release

Release has gone through a similar tidy up to deploy. Arguably a shared workflow could be built for this, but it felt prudent to keep it separate for now. When signing is fully available we can take a look at it then.

• All S3 actions now use the official AWS tools
• Only RPM + OSX needs an extra tool outside what comes by default

Example here: https://github.com/KSP-CKAN/CKAN/actions/runs/8936371852

Other things of note

• Signing is waiting upon verification of the GitHub Action, it'll be a small amount of work to switch to the signed binaries
• I used a /test path for all S3 uploads, which look to have worked in the same manner as the previous action.

[HebaruSan]

Found a couple of things that look like they need more attention.

But I love the overall approach here, and I'm really looking forward to using these nicely refactored workflows!

[techman83]

Found a couple of things that look like they need more attention.

But I love the overall approach here, and I'm really looking forward to using these nicely refactored workflows!

Awesome! I note the dotnet action was removed, now I'm aware it's a no-op, because they are available by default. But that may not always be the case, and we are setting version 7 specifically. So it wasn't an accident that they appeared again.

I guess if it stops working in the future we can just add it back in, but it is useful for using things like 'act' for local testing, that may not have all actions cached locally.

[HebaruSan]

Awesome! I note the dotnet action was removed, now I'm aware it's a no-op, because they are available by default.

Yup, trying to review these changes made me particularly aware how much mental bandwidth I was dedicating to, "Oh, that's unnecessary, I can just ignore those 4 lines." Better to not have them there at all.

[techman83]

Alright, I think that's everything!

[HebaruSan]

Agree, looks good to me. Let's go!