Various fixes for the refactored workflows #4091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
version.json
file from Support dev builds for auto updater #3997 isn't being generated anymore. I assume Refactor + Modernise Actions #4082 removed this because of some sort of Python dependency issues in the newer containers, but we still need it.upload-nuget
inrelease.yml
was trying to download aRelease-repack-out
artifact that doesn't exist (it's justRelease-out
)upload-release-s3
indeploy.yml
tightly couples checking for odd builds with a job that doesn't even need that, which should be done in a shorter, standalone jobCredentials
step ofdeploy.yml
is weird. I cannot figure out what it's supposed to be doing. It sets acredentials
output tofalse
if the credentials do exist, whereas that name suggests to me it would betrue
if the credentials exist andfalse
if they don't. But if the credentials don't exist, then thecredentials
output isn't set at all, which still means false in workflow expression syntax! So the meaning and purpose of thecredentials
output is very unclear. It is used as a condition in a couple of other jobs that somehow always run even though they depend on an output that's always false.Changes
version.json
is once again created and uploaded to S3. I'm expecting this to fail due to Python's extreme environmental sensitivity, but I'll fight withdeploy.yml
about it after merge.Release-out
andDebug-out
artifacts are renamedRelease-out-unsigned
andDebug-out-unsigned
.odd-build
output is renameddev-build
and is now generated by a smaller, simplercheck-dev-build
job with no side effects. Jobs that need this info are updated toneeds
this job instead ofupload-release-s3
.credentials
output stuff is removed, and theaws-actions/configure-aws-credentials
steps are moved to be the first in their jobs so if the credentials are missing, the job stops early. If there's a reason why it was like that, then I'll find out what it was after merge.