Refactor Git Repos #288
Merged
Refactor Git Repos #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techman83
force-pushed
the
refactor/git-repos
branch
2 times, most recently
from
ee03890 to
304f601
Compare
This was referenced Mar 29, 2023
techman83
force-pushed
the
refactor/git-repos
branch
from
304f601 to
1a7694e
Compare
HebaruSan
reviewed
Apr 7, 2023
HebaruSan
requested changes
Apr 7, 2023
Many assumptions around branches and repos were made early on, since then we moved a lot of the common repo actions into relevant classes. This furthers that work and replaces all direct branch access with methods that automatically figure out the primary branch of the repo. Tests updated to reference 'main'
techman83
force-pushed
the
refactor/git-repos
branch
from
1a7694e to
211b6a6
Compare
HebaruSan
approved these changes
Apr 8, 2023
|
Resolved the bad merge conflict resolution, and removed all the reformatting. I think I'd like to switch to black for the project, but I'd rather not mix in formatting with refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many assumptions around branches and repos were made early on, since then we moved a lot of the common repo actions into relevant classes. This furthers that work and replaces all direct branch access with methods that automatically figure out the primary branch of the repo. Tests updated to reference 'main'
It is intended that #283 is reviewed and merged first, then once happy we can move onto this in preparation for adding KSP2 config. We will be able to follow soon after by renaming master -> main for the existing KSP repos.