Automatically Iterate Games + Add KSP2 Config #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techman83
force-pushed
the
refactor/utilities
branch
2 times, most recently
from
afc4378 to
fed152b
Compare
|
@HebaruSan - this will still require rebasing of the git-repos work, but I have reabsed off master to make it a bit easier to review |
techman83
force-pushed
the
refactor/utilities
branch
from
828e113 to
d550541
Compare
HebaruSan
reviewed
Apr 8, 2023
Instead of needing to setup utilities to run per game, we can iterate through. There is likely scope for this to be improved further, but this will bring ksp2 on reasonably quickly.
This adds the relevant configuration for KSP2 indexing
It was unnesscary to add a class property for processed, this was a holdover from how the class was previously written, and caused an issue as it essentially built up until trying to send more than 10 for a delete to SQS, causing an exception. Now the list is a local variable and the handler returns the entries as requried for the queue to delete them, avoiding the possibility of it growing beyond the messages as set by MaxNumberOfMessages
ECS uses cloudwatch to schedule tasks, and needs to be able to pass through the IAM, to which the scheduler needs permission to do that. Though the tasks are being renamed back, this prevents a situation in the future where we add/change a task and wonder why it does not invoke and have limited ability to diagnose beyond seeing it fail to invoke.
techman83
force-pushed
the
refactor/utilities
branch
from
42ca905 to
c000c6f
Compare
HebaruSan
approved these changes
Apr 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to come after #283 + #288 - will rebase when ready
Adds
gamesmethod that automatically returns a list of the configured gamesChanges
Fixes
processedfrom the QueueHandler, avoiding the risk of the list growing perpetually until SQS throws an exceptionExtra