Force default Scatterer-sunflare for Spectra #7870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In #7663, we tried to set up Spectra's relationships to reflect its Scatterer config and sunflare files. However, this was wrong, because Spectra does not provide a full config as in #3950, but instead patches the default config as in #7741.
In #7706 we fixed that problem for the Scatterer-config side of things.
Problem
The sunflare relationship is still set up as if Spectra provided a full sunflare config, but instead it patches the default sunflare config, which then doesn't work.
Changes
Now Spectra uses the approach we started in #7794 to pull in the default sunflare.
(Replaces KSP-CKAN/CKAN-meta#1905.)