Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate CKAN-meta PRs with netkan.exe #52

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

HebaruSan
Copy link
Member

With KSP-CKAN/CKAN#2819 merged, we can now use netkan.exe --validate-ckan to validate .ckan files according to the tests in KSP-CKAN/CKAN#2788.

This pull request does that for pull requests in the CKAN-meta repo. Since netkan.exe performs schema validation, CKAN.schema and ckan-validate.py are no longer downloaded or used.

There was some discussion of erroring out if the .ckan file doesn't exactly match the nicely sorted pretty-printed output of netkan.exe. For now this is not done; we have a lot of old metadata, and it would be annoying for maintenance if we could not make simple small changes to such files and merge them.

@techman83
Copy link
Member

There was some discussion of erroring out if the .ckan file doesn't exactly match the nicely sorted pretty-printed output of netkan.exe. For now this is not done; we have a lot of old metadata, and it would be annoying for maintenance if we could not make simple small changes to such files and merge them.

I'm less concerned by this. All of our old metadata was reprocessed when I built a bot to back fill all the hashes and upload to archive.org where license allowed. Anything that doesn't have a hash is likely dead metadata and likely not something we'll be altering anytime soon. So the otherwhelming majority of the metadata has been produced by NetKAN in some shape or form (be that via the indexer, the backfill bot or via PR).

This pull request does that for pull requests in the CKAN-meta repo. Since netkan.exe performs schema validation, CKAN.schema and ckan-validate.py are no longer downloaded or used.

Woooooooo!

@techman83 techman83 merged commit 3159c57 into KSP-CKAN:master Jul 1, 2019
@HebaruSan HebaruSan deleted the feature/netkan-ckan-validate branch July 1, 2019 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants