Validate CKAN-meta PRs with netkan.exe #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With KSP-CKAN/CKAN#2819 merged, we can now use
netkan.exe --validate-ckan
to validate .ckan files according to the tests in KSP-CKAN/CKAN#2788.This pull request does that for pull requests in the CKAN-meta repo. Since
netkan.exe
performs schema validation,CKAN.schema
andckan-validate.py
are no longer downloaded or used.There was some discussion of erroring out if the .ckan file doesn't exactly match the nicely sorted pretty-printed output of
netkan.exe
. For now this is not done; we have a lot of old metadata, and it would be annoying for maintenance if we could not make simple small changes to such files and merge them.