Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let netkan validation print directly to stdout #53

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

HebaruSan
Copy link
Member

In #52 we set up the CKAN-meta PR script to validate its input files with netkan.exe.

However, the errors are not printed.

https://ci.ksp-ckan.space/job/CKAN-meta/1125/console

Validating metadata: 'AircraftCarrierAccessories/AircraftCarrierAccessories-1-1.2.1.ckan'
Build step 'Execute shell' marked build as failure
Discard old builds...
#1091 is removed because it is older than daysToKeep
#1090 is removed because it is older than daysToKeep
#1089 is removed because it is older than daysToKeep
#1088 is removed because it is older than daysToKeep
#1087 is removed because it is older than daysToKeep
Stopping all containers

Apparently the return value of a $() command still causes a script to terminate, so we don't have a chance to print the error message after it fails.

Now we no longer intercept the output of this command. This will allow us to see the errors when validation fails. Since it will print a nicely formatted version of the input file on success, the cat "$ckan" line is removed as redundant.

@HebaruSan HebaruSan merged commit 81ad931 into master Jul 3, 2019
@HebaruSan HebaruSan deleted the HebaruSan-patch-val branch July 3, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant