Let netkan validation print directly to stdout #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #52 we set up the CKAN-meta PR script to validate its input files with
netkan.exe
.However, the errors are not printed.
https://ci.ksp-ckan.space/job/CKAN-meta/1125/console
Apparently the return value of a
$()
command still causes a script to terminate, so we don't have a chance to print the error message after it fails.Now we no longer intercept the output of this command. This will allow us to see the errors when validation fails. Since it will print a nicely formatted version of the input file on success, the
cat "$ckan"
line is removed as redundant.