Fixes #1926 - wave init for voices 6 through 9. #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was caused by SoundMaker.SetWave(). It contained a protection check to try to prevent us from using it to set a voice index number that doesn't exist. (i.e. trying to call SetWave(11,"sine"), when there is no such thing as voice 11). The problem is that the check it was performing was comparing the index to how many WAVEFORMS were defined, instead of how many VOICES were. So because there are 5 defined waveforms, but 10 defined voices, it refused to operate on voices 6,7,8,9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by SoundMaker.SetWave().
It contained a protection check to try to prevent us from using
it to set a voice index number that doesn't exist. (i.e.
trying to call SetWave(11,"sine"), when there is no such thing
as voice 11).
The problem is that the check it was performing was comparing
the index to how many WAVEFORMS were defined, instead of
how many VOICES were. So because there are 5 defined waveforms,
but 10 defined voices, it refused to operate on voices 6,7,8,9.