Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1926 - wave init for voices 6 through 9. #1927

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Fixes #1926 - wave init for voices 6 through 9. #1927

merged 1 commit into from
Jan 27, 2017

Commits on Jan 13, 2017

  1. Fixes #1926 - wave init for voices 6 through 9. 

    The problem was caused by SoundMaker.SetWave().

It contained a protection check to try to prevent us from using
it to set a voice index number that doesn't exist.  (i.e.
trying to call SetWave(11,"sine"), when there is no such thing
as voice 11).

The problem is that the check it was performing was comparing
the index to how many WAVEFORMS were defined, instead of
how many VOICES were.  So because there are 5 defined waveforms,
but 10 defined voices, it refused to operate on voices 6,7,8,9.
    @Dunbaratu
    Dunbaratu committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    42dc25f View commit details
    Browse the repository at this point in the history