Added features described in issue #2319 #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Dickinson <evan_dickinson@protonmail.com>
evandisoft
changed the title
Dunbaratu
reviewed
Nov 13, 2018
| @@ -67,6 +67,9 @@ All of the main celestial bodies in the game are reserved variable names. The fo | |||
| :attr:`NAME` :ref:`string <string>` | |||
| :attr:`DESCRIPTION` :ref:`string <string>` | |||
| :attr:`MASS` :ref:`scalar <scalar>` (kg) | |||
| :attr:`OCEAN` :ref:`boolean <boolean>` | |||
There was a problem hiding this comment.
I think this should probably be named with the word "HAS" in front of it, to make it consistent with many of the other similar boolean suffixes like this (i.e. call it "HASOCEAN").
Thanks for the contribution, by the way!
There was a problem hiding this comment.
You're welcome. Fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to issue #2319.
I don't have much experience contributing to projects on Github like this. Hoping to start doing this sort of thing a lot.
Hope I did everything correctly. If not, let me know and I'll fix it.
Also, I modified the .gitignore so that it stopped committing my vim .swp files. Hope that is ok. If not, I can just not use Vim.