Bounding box #2564
Merged
Bounding box #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fb08141.
The original 8-corner bounds transform was necessary after all, so this reverted the "savings" of only doing 2 corners and put the origianl 8-corner logic back for parts' bounds. Also, Vessel bounds was always using 2-corner logic and was wrong all along - this is adding the 8-corner logic to it too. Special thanks to @RCrockford in kOS discord for warning me about this when I discussed my plan, thus making me check again with a more complete test to catch that my idea didn't really cover all situations (for the 2 corner method to fail you have to be oriented a specific way relative to the axes, and on the runway at KSC just so happened to NOT trigger that case so it wasn't clear that it was wrong till I went into orbit and tried again there where I could spin all axes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix to broken 2-corner logic (putting 8-corner logic back) in PR #2563