Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bounding box #2564

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Bounding box #2564

merged 2 commits into from
Jul 18, 2019

Commits on Jul 18, 2019

  1. Revert "reduce bounding box work - calc 2 corners not 8." 

    This reverts commit fb08141.
    @Dunbaratu
    Dunbaratu committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    48ed54f View commit details
    Browse the repository at this point in the history

  2. @RCrockford pointed out my 2 corner bounds is bad. 

    The original 8-corner bounds transform was necessary after all,
so this reverted the "savings" of only doing 2 corners and
put the origianl 8-corner logic back for parts' bounds.

Also, Vessel bounds was always using 2-corner logic and was
wrong all along - this is adding the 8-corner logic to it too.

Special thanks to @RCrockford in kOS discord for warning me
about this when I discussed my plan, thus making me check
again with a more complete test to catch that my idea didn't
really cover all situations (for the 2 corner method to fail
you have to be oriented a specific way relative to the axes,
and on the runway at KSC just so happened to NOT trigger that
case so it wasn't clear that it was wrong till I went into
orbit and tried again there where I could spin all axes.
    @Dunbaratu
    Dunbaratu committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    2b9b5d5 View commit details
    Browse the repository at this point in the history