Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologize for making a pull request that attempts to address two things at once:
First item:
I have added a couple conflicting packages to the express-install package. I blocked the outdated SmokeScreen-RO and CustomBarnKit-RO packages, as if a user has ckan compatiblity with older versions of ksp enabled, the express install will ask the user to pick between them and the up-to-date versions with the current metadata.
More controversially, I also blocked SCANsat, StageRecovery, and KerbalEngineerRedux. These mods are all of the mods on "The Blacklist" that are available on ckan. SCANsat and KER can both be made compatible with additional work after installation, but this falls into the realm of an "advanced user" who can use the non-express install if they want to use those mods.
It is more important, imo, to assure that the express install "just works" than to make it easy to customize. The adjustments I made to the non-express install make it much easier to use, so advanced users who do want to use those mods shouldn't find it too difficult to switch over from the express install.
Second item:
Currently, the express install package asks you to select a graphics preset, and it is the graphics preset metapackage that does the real "meat and potatoes" of installing ROEngines, ROTanks, etc. In conjunction with this "sister" PR, I would like to move the non-graphical dependencies out of the preset metapackages and into the express install itself. This makes the differences between the graphical presets easier to understand, makes it clearer to users what the express-install is actually doing, and makes maintaining the packages just a touch easier. The non-graphical dependencies between all 3 preset metapackages are already identical, so there are no changes to the actual end result of the installation.
I am happy to resubmit an edited PR if only one of the two changes is desired.