Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Recommended/Suggested packages in ckan #2205

Merged
merged 7 commits into from
Sep 18, 2023

Conversation

Qazerowl
Copy link
Contributor

@Qazerowl Qazerowl commented Aug 29, 2023

The current ckan metadata for the RP-1 package does not match the more up-to-date recommended extra mods list on the wiki. I have fixed this along with a couple other minor improvements:

  • Updated .netkan to most recent spec/format
  • Corrected license (now automatically pulls from this repo's metadata)

I did not make any changes to the dependencies or conflicting packages, only recommended/suggested. The following types of packages were set to be recommended by the core RP-1 package:

  • All packages that are required by the express install
  • All packages that are recommended by the express install
  • The 3 packages that are described as "highly recommended" on the wiki: Principia, kOS, and Docking Port Sound FX.

All of the remaining mods on that wiki page were set to suggested. No other mods are set to recommended or suggested.

I believe there are two things that somebody could object to. First: the current netkan recommendations offer choices between TestFlight/TestLite, RCSBuildAid/RCSBuildAidContinued, and VenStockRevamp/Restock. I have elected to simply recommend only the option that is installed by the express installer. There is nothing stopping a user from simply installing a different option if they wish to do so, I think this simplification is for the better.
The second thing to object to is that I included Principia. I know it is not on ckan. I know it will probably never be on ckan. I think because it is "highly recommended" that it should be included. Doing so will not cause any errors during installation, it will simply serve as a reminder to install it should anybody bother to read the list of recommended mods in the sidebar of ckan.

Please let me know if any changes are requested, or if you disagree with where I drew the line between recommended and suggested. Keep in mind that this is not a change to the express installer at all, just the core package for advanced user installation. (And more importantly, this fixes what a user will see after manually running a recommendations audit after an express install).
I can also update the "RP-0" version of this config if so desired.

@NathanKell
Copy link
Member

I think we probably need to figure out whether we still want to Highly Recommend kOS. Also, I'm kinda concerned about the Principia dep. @HebaruSan are there any downsides to it? From a CKAN perspective--I assume the user-facing downside is that it may be confusing.

Apart from that, looks great! Thanks!!

@HebaruSan
Copy link
Contributor

Also, I'm kinda concerned about the Principia dep. @HebaruSan are there any downsides to it? From a CKAN perspective--I assume the user-facing downside is that it may be confusing.

Hi @NathanKell, no downsides that I know of. As @Qazerowl says, it will be visible in the Relationships tab if someone is browsing the main mod list, but recommendations that can't be satisfied are hidden during installation.

(BTW, I did do some further investigation trying to address the technical side of adding Principia to CKAN, and it's even uglier than I imagined. Nobody in the OS space seems to care about letting us query for an installed library conveniently. On Windows we either have to memorize a list of dozens of UUIDs to pass to an MSI-related API call or use an outdated library that does that for us. On Linux we can run ldconfig -p, but it doesn't include any versioning, so there's no way to be sure the user has the right version of libc++.so.1 and libc++abi.so.1. Mac is the most straightforward since Principia just requires an overall OS version, which .NET/Mono provides.)

@NathanKell
Copy link
Member

We'd like to keep the any_of for restock vs Ven's, and TF vs TL, but apart from that I think this is good to merge! Sorry for the delay on this, got sucked into some RL stuff.

now offers the option to pick between TF/TL and ReStock(+)/Ven's on the recommendations screen
RP-1.netkan Outdated Show resolved Hide resolved
@NathanKell
Copy link
Member

Looks good to me, thank you! Gonna merge this when we ship the next update of RP-1 since it will no longer depend on magicore.

@NathanKell NathanKell merged commit 45d61a7 into KSP-RO:master Sep 18, 2023
3 checks passed
@Qazerowl Qazerowl deleted the ckan-metadata branch October 16, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants