Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese Leader Update. #2316

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Chinese Leader Update. #2316

merged 3 commits into from
Jun 19, 2024

Conversation

Proxima-b
Copy link
Contributor

I noticed an unused leader icon in the file.
Plan to expand upon it.

I noticed an unused leader icon in the file.
Plan to expand upon it.
@Proxima-b Proxima-b marked this pull request as draft December 18, 2023 15:37
@Proxima-b Proxima-b marked this pull request as ready for review December 18, 2023 16:04
@Capkirk123
Copy link
Member

Is this finished?

@Proxima-b
Copy link
Contributor Author

Is this finished?

Technically it is, the thing is, there was already an picture of that scientist in the files.
This PR is only aimed to complete the that specific unused asset, not as a fully complete chinese leader update.

@Capkirk123
Copy link
Member

Probably a little week, but eh. Ship now, balance later.

@Capkirk123 Capkirk123 merged commit 56a48f4 into KSP-RO:master Jun 19, 2024
@Proxima-b
Copy link
Contributor Author

Probably a little week, but eh. Ship now, balance later.

Tried a little, The leader does lack significant impact, maybe increase the integration rate for another 5%, make him a rush option, considering the Reputation malus ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants