Course automation: Notification for proposal-PR new comments #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created new proposal.
|
An alternative approach would be to instead provide notification of a proposal-PR review's result (approve, request changes). This assumes that the review functionality is used for proposals 😁 |
cesarsotovalero
approved these changes
Mar 25, 2021
|
Hi @isacarvid, the originally proposed functionality is good. I suggest you give the students the choice to use the action or not. For example, you can allow using some wildcard word for setting on/off the action (which should be off by default). This way, students who don't want to be notified are not going to receive email alerts. |
cesarsotovalero
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Course automation: Email notification for proposal-PR new comments
Members
Ayub Atif (aatif@kth.se)
GitHub: ayubatif
Isac Arvidsson (isacarv@kth.se)
Github: isacarvid
Proposal
We want to send a notification via email to all PR group members when a new comment on a proposal-PR has been made(new comment, approved, request changes). The problem arises as only the author of the PR would receive a notification normally, leaving the other members without knowledge of needed changes. Thereby providing an improvement to the course automation experience.
The requirements for the actions are: