Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course automation: Notification for proposal-PR new comments #958

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Course automation: Notification for proposal-PR new comments #958

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebaa82a
Create README.md for proposal
isacarvid Mar 23, 2021
aa4f9de
Update README.md
isacarvid Mar 23, 2021
ceca2af
Update README.md
isacarvid Mar 23, 2021
49d06a1
Update README.md
cesarsotovalero Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions contributions/course-automation/isacarvid-aatif/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@

# Course automation: Email notification for proposal-PR new comments

## Members
Ayub Atif (aatif@kth.se)
GitHub: [ayubatif](https://github.com/ayubatif)

Isac Arvidsson (isacarv@kth.se)
Github: [isacarvid](https://github.com/isacarvid)

## Proposal

We want to send a notification via email to all PR group members when a new comment on a proposal-PR has been made. The problem arises as only the author of the PR would receive a notification normally, leaving the other members without knowledge of needed changes. Thereby providing an improvment to the course automation experience.

The requirements for the actions are:

- When a proposal-PR is commented it triggers github actions.
- Parse README.md to find all members.
- Include title of PR.
- Include the new comment.
- Send email to all group members.

Note: The student can set on/off the notification (it will be off by default). This way, students who don't want to be notified are not going to receive email alerts.