Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to save settings per-workspace #383

Merged
merged 13 commits into from
Aug 10, 2024
Merged

Add option to save settings per-workspace #383

merged 13 commits into from
Aug 10, 2024

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Aug 4, 2024

Relevant Issues

List any closed and/or relevant issues

Changes Made

List any changes made.

  • Add typecheck to build
  • Adds option to save background settings to workspace
  • Install uses workspace with global fallback
  • Background menu uses workspace without fallback
  • Background menu specifies global value
  • Default is returned in all cases

Release Notes

This updates the configuration menu to allow workspace specific settings; to use workspace, toggle the Setting Scope in the more options menu. Does not automatically update the background on workspace switch, the Auto Install option needs to also be turned on.

Setting this to workspace will always use the workspace configuration, it does not fallback to global settings.

@Katsute Katsute self-assigned this Aug 4, 2024
@Katsute Katsute changed the title workspace setting Add option to save settings per-workspace Aug 4, 2024
@Katsute Katsute mentioned this pull request Aug 6, 2024
@Katsute Katsute added the v3 label Aug 6, 2024
@Katsute Katsute marked this pull request as ready for review August 7, 2024 01:19
@Katsute
Copy link
Member Author

Katsute commented Aug 7, 2024

When using workspace, menu should get workspace or default, not global. Menu should say the global value alongside the workspace one.

@Katsute
Copy link
Member Author

Katsute commented Aug 9, 2024

Fallback causes unexpected behavior with array settings, setting any one will not fallback the rest of the values which is counter intuitive.

Workspace option will only pull in workspace.

@Katsute

This comment has been minimized.

Copy link
Contributor

@kdevbot kdevbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @Katsute

@Katsute Katsute added this pull request to the merge queue Aug 10, 2024
Merged via the queue into main with commit 89a4751 Aug 10, 2024
10 checks passed
@Katsute Katsute deleted the workspace@d95a840 branch August 10, 2024 00:31
@kdevbot kdevbot bot locked and limited conversation to collaborators Aug 10, 2024
@Katsute Katsute added this to the M3 milestone Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace Specific Configuration
1 participant