Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
## Summary: There’s an issue with wb-cell that was introduced after making some layout/css changes to the components. Turns out that Cell states won’t be displayed as expected when the cell top node is `display: inline`. As cells are meant to use the full-width of it’s parent container, this PR fixes that by making the top node to always use `display: flex`. Issue: https://khanacademy.atlassian.net/browse/WB-1623 ## Test plan: Verify that cell states are displayed as expected (hover, active change the bg color). Author: jandrade Reviewers: jeresig, adinardi Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Chromatic - Get results on non-draft regular PRs (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 2/2), ✅ Lint (ubuntu-latest, 16.x), ✅ Check build sizes (ubuntu-latest, 16.x), ✅ Test (ubuntu-latest, 16.x, 1/2), ✅ Chromatic - Build on non-draft regular PRs / chromatic (ubuntu-latest, 16.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 16.x), ⏭ Chromatic - Skip on Release PR (changesets), ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ⏭ dependabot Pull Request URL: #2073
- Loading branch information