-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WB-1623: Cell states don't work with anchor tags correctly [fix] #2073
Conversation
🦋 Changeset detectedLatest commit: 3994c7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Size Change: +11 B (0%) Total Size: 89.9 kB
ℹ️ View Unchanged
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (e6c6c12) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2073" Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2073 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2073 +/- ##
==========================================
+ Coverage 96.93% 96.96% +0.03%
==========================================
Files 236 236
Lines 26651 26652 +1
Branches 2356 2307 -49
==========================================
+ Hits 25835 25844 +9
+ Misses 816 808 -8
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-pbngwyijtg.chromatic.com/ Chromatic results:
|
yay thanks! |
Summary:
There’s an issue with wb-cell that was introduced after making some layout/css
changes to the components.
Turns out that Cell states won’t be displayed as expected when the cell top node
is
display: inline
. As cells are meant to use the full-width of it’s parentcontainer, this PR fixes that by making the top node to always use
display: flex
.Issue: https://khanacademy.atlassian.net/browse/WB-1623
Test plan:
Verify that cell states are displayed as expected (hover, active change the bg
color).