Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1623: Cell states don't work with anchor tags correctly [fix] #2073

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

jandrade
Copy link
Member

Summary:

There’s an issue with wb-cell that was introduced after making some layout/css
changes to the components.

Turns out that Cell states won’t be displayed as expected when the cell top node
is display: inline. As cells are meant to use the full-width of it’s parent
container, this PR fixes that by making the top node to always use display: flex.

Issue: https://khanacademy.atlassian.net/browse/WB-1623

Test plan:

Verify that cell states are displayed as expected (hover, active change the bg
color).

@jandrade jandrade self-assigned this Sep 29, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2023

🦋 Changeset detected

Latest commit: 3994c7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@khanacademy/wonder-blocks-cell Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team September 29, 2023 16:34
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Sep 29, 2023

Gerald

Required Reviewers
  • @Khan/wonder-blocks for changes to package.json, .changeset/hot-starfishes-sleep.md, .github/workflows/node-ci-pr.yml, packages/wonder-blocks-cell/src/components/internal/cell-core.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@jandrade jandrade requested a review from adinardi September 29, 2023 16:35
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

Size Change: +11 B (0%)

Total Size: 89.9 kB

Filename Size Change
packages/wonder-blocks-cell/dist/es/index.js 2.19 kB +11 B (+1%)
ℹ️ View Unchanged
Filename Size
packages/wonder-blocks-accordion/dist/es/index.js 55 B
packages/wonder-blocks-banner/dist/es/index.js 3.06 kB
packages/wonder-blocks-birthday-picker/dist/es/index.js 1.69 kB
packages/wonder-blocks-breadcrumbs/dist/es/index.js 1.13 kB
packages/wonder-blocks-button/dist/es/index.js 3.98 kB
packages/wonder-blocks-clickable/dist/es/index.js 3.21 kB
packages/wonder-blocks-color/dist/es/index.js 1.15 kB
packages/wonder-blocks-core/dist/es/index.js 3.67 kB
packages/wonder-blocks-data/dist/es/index.js 6.33 kB
packages/wonder-blocks-dropdown/dist/es/index.js 12 kB
packages/wonder-blocks-form/dist/es/index.js 5.42 kB
packages/wonder-blocks-grid/dist/es/index.js 1.36 kB
packages/wonder-blocks-i18n/dist/es/index.js 4.54 kB
packages/wonder-blocks-icon-button/dist/es/index.js 2.15 kB
packages/wonder-blocks-icon/dist/es/index.js 3.04 kB
packages/wonder-blocks-labeled-field/dist/es/index.js 72 B
packages/wonder-blocks-layout/dist/es/index.js 1.87 kB
packages/wonder-blocks-link/dist/es/index.js 3.03 kB
packages/wonder-blocks-modal/dist/es/index.js 5.02 kB
packages/wonder-blocks-pill/dist/es/index.js 1.03 kB
packages/wonder-blocks-popover/dist/es/index.js 4.31 kB
packages/wonder-blocks-progress-spinner/dist/es/index.js 1.51 kB
packages/wonder-blocks-search-field/dist/es/index.js 1.5 kB
packages/wonder-blocks-spacing/dist/es/index.js 158 B
packages/wonder-blocks-switch/dist/es/index.js 2.06 kB
packages/wonder-blocks-testing/dist/es/index.js 3.94 kB
packages/wonder-blocks-theming/dist/es/index.js 1.21 kB
packages/wonder-blocks-timing/dist/es/index.js 1.78 kB
packages/wonder-blocks-toolbar/dist/es/index.js 862 B
packages/wonder-blocks-tooltip/dist/es/index.js 5.05 kB
packages/wonder-blocks-typography/dist/es/index.js 1.49 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

npm Snapshot: Published

🎉 Good news!! We've packaged up the latest commit from this PR (e6c6c12) and published all packages with changesets to npm.

You can install the packages in webapp by running:

./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2073"

Packages can also be installed manually by running:

yarn add @khanacademy/wonder-blocks-<package-name>@PR2073

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #2073 (3994c7f) into main (b32ec45) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2073      +/-   ##
==========================================
+ Coverage   96.93%   96.96%   +0.03%     
==========================================
  Files         236      236              
  Lines       26651    26652       +1     
  Branches     2356     2307      -49     
==========================================
+ Hits        25835    25844       +9     
+ Misses        816      808       -8     
Files Coverage Δ
...-blocks-cell/src/components/internal/cell-core.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b32ec45...3994c7f. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-pbngwyijtg.chromatic.com/

Chromatic results:

Metric Total
Captured snapshots 309
Tests with visual changes 0
Total stories 365
Inherited (not captured) snapshots [TurboSnap] 0
Tests on the build 309

@jandrade jandrade merged commit bf5a2d4 into main Sep 29, 2023
13 checks passed
@jandrade jandrade deleted the cell-flex-fix branch September 29, 2023 17:19
@adinardi
Copy link
Member

yay thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants