Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the header for the vulkan-shader-profiler embedded reflection… #398

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

rjodinchr
Copy link
Contributor

… non-semantic instruction set

vulkan-shader-profiler is a tool based on perfetto to help vulkan developer profil their applications.
First on the Host side using perfetto, but then using the extractor and the runner, this tools allow to get inside about a shader using counters (based on SPV_KHR_shader_clock)

… non-semantic instruction set

vulkan-shader-profiler is a tool based on perfetto to help vulkan
developer profil their applications.
First on the Host side using perfetto, but then using the extractor
and the runner, this tools allow to get inside about a shader using
counters (based on SPV_KHR_shader_clock)
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
SPIR WG will do final approval.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the spec for this extended instruction set posted anywhere? I don't see a SPIRV-Registry PR or similar. It's not strictly required, but I can't really comment on the content of these changes without a spec to compare against - thanks!

@rjodinchr
Copy link
Contributor Author

Is the spec for this extended instruction set posted anywhere? I don't see a SPIRV-Registry PR or similar. It's not strictly required, but I can't really comment on the content of these changes without a spec to compare against - thanks!

I don't intend to have anything in the SPIRV-Registry for that extended instruction set.

@rjodinchr rjodinchr requested a review from bashbaug January 10, 2024 07:05
Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as discussed in the January 10th teleconference.

@bashbaug bashbaug merged commit 2e3dc2e into KhronosGroup:main Jan 10, 2024
10 checks passed
@rjodinchr rjodinchr deleted the vksp branch January 11, 2024 06:37
@rjodinchr rjodinchr restored the vksp branch January 11, 2024 06:59
@bashbaug bashbaug mentioned this pull request Jan 12, 2024
rjodinchr added a commit to rjodinchr/SPIRV-Tools that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants