-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish the header for the vulkan-shader-profiler embedded reflection… #398
Conversation
… non-semantic instruction set vulkan-shader-profiler is a tool based on perfetto to help vulkan developer profil their applications. First on the Host side using perfetto, but then using the extractor and the runner, this tools allow to get inside about a shader using counters (based on SPV_KHR_shader_clock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
SPIR WG will do final approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the spec for this extended instruction set posted anywhere? I don't see a SPIRV-Registry PR or similar. It's not strictly required, but I can't really comment on the content of these changes without a spec to compare against - thanks!
Co-authored-by: Ben Ashbaugh <ben.ashbaugh@intel.com>
This reverts commit 3c9c24d.
I don't intend to have anything in the SPIRV-Registry for that extended instruction set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging as discussed in the January 10th teleconference.
… non-semantic instruction set
vulkan-shader-profiler is a tool based on perfetto to help vulkan developer profil their applications.
First on the Host side using perfetto, but then using the extractor and the runner, this tools allow to get inside about a shader using counters (based on SPV_KHR_shader_clock)