Type for copy and fill should be device-copyable #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that the type used in the `handler::copy` and `handler::fill` functions must be "device copyable". This avoids confusion when `T` is a class type because people might expect the class's copy constructor to be called, when our intent is that the implementation should just do a byte copy. There is no need to clarify the element type of the accessors in these functions becuse we already state that the element type of a buffer must be device copyable. Therefore, this PR only changes the wording for the non-accessor parameters.
TApplencourt
approved these changes
Jun 8, 2023
|
LGTM |
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 12, 2023
…#8826) `cgh.fill(...)` was failing when `T` is a `sycl::vec` type, since `sycl::vec` types have no specialization for `std::is_trivially_copyable`. Since `device_copyable` is a sycl superset of trivially copyable we should use this instead in sycl headers. Related spec change: KhronosGroup/SYCL-Docs#425
0x12CC
added a commit
to 0x12CC/llvm
that referenced
this pull request
Jun 12, 2023
KhronosGroup/SYCL-Docs#425 clarifies that the source type for the `copy` must be device copyable. Remove the copy from `const void *` test case since it fails this assertion. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 13, 2023
KhronosGroup/SYCL-Docs#425 clarifies that the source type for the `copy` must be device copyable. Remove the copy from `const void *` test case since it fails this assertion. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
fineg74
pushed a commit
to fineg74/llvm
that referenced
this pull request
Jun 15, 2023
KhronosGroup/SYCL-Docs#425 clarifies that the source type for the `copy` must be device copyable. Remove the copy from `const void *` test case since it fails this assertion. Signed-off-by: Michael Aziz <michael.aziz@intel.com>
keryell
added a commit
that referenced
this pull request
Sep 10, 2024
Clarify that the type used in the handler::copy and handler::fill functions must be "device copyable". This avoids confusion when T is a class type because people might expect the class's copy constructor to be called, when our intent is that the implementation should just do a byte copy. There is no need to clarify the element type of the accessors in these functions becuse we already state that the element type of a buffer must be device copyable. Therefore, this PR only changes the wording for the non-accessor parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that the type used in the
handler::copyandhandler::fillfunctions must be "device copyable". This avoids confusion whenTis a class type because people might expect the class's copy constructor to be called, when our intent is that the implementation should just do a byte copy.There is no need to clarify the element type of the accessors in these functions becuse we already state that the element type of a buffer must be device copyable. Therefore, this PR only changes the wording for the non-accessor parameters.