Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Remove invalid copy test case #9829

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Jun 12, 2023

KhronosGroup/SYCL-Docs#425 clarifies that the source type for the copy must be device copyable. Remove the copy from const void * test case since it fails this assertion.

KhronosGroup/SYCL-Docs#425 clarifies that the source type for the `copy`
must be device copyable. Remove the copy from `const void *` test case
since it fails this assertion.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
@0x12CC 0x12CC requested a review from a team as a code owner June 12, 2023 20:17
@0x12CC 0x12CC temporarily deployed to aws June 12, 2023 20:26 — with GitHub Actions Inactive
@0x12CC 0x12CC temporarily deployed to aws June 12, 2023 21:07 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. What would it even mean to copy N const void values?

@steffenlarsen steffenlarsen merged commit dc48d7c into intel:sycl Jun 13, 2023
@0x12CC 0x12CC deleted the copy_from_void branch June 13, 2023 13:17
fineg74 pushed a commit to fineg74/llvm that referenced this pull request Jun 15, 2023
KhronosGroup/SYCL-Docs#425 clarifies that the source type for the `copy`
must be device copyable. Remove the copy from `const void *` test case
since it fails this assertion.

Signed-off-by: Michael Aziz <michael.aziz@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants