Skip to content

Add 'relative: bool' to tanArcTo, remove 'to' mode from tanArc #995

Add 'relative: bool' to tanArcTo, remove 'to' mode from tanArc

Add 'relative: bool' to tanArcTo, remove 'to' mode from tanArc #995

Triggered via pull request August 29, 2024 19:17
Status Failure
Total duration 6m 30s
Artifacts

build-test-web.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
src/lang/modifyAst.test.ts > testing sketchOnExtrudedFace > it should be able to extrude on regular segments: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 2966 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ src/lang/modifyAst.test.ts:328:21
src/lang/modifyAst.test.ts > testing sketchOnExtrudedFace > it should ensure that the new sketch is inserted after the extrude: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 7010 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ src/lang/modifyAst.test.ts:452:21
src/lang/modifyAst.test.ts > Testing removeSingleConstraintInfo > with mostly object notation > stdlib fn: tangentialArcTo([3.14 + 0, 13.14], false, %): src/lang/modifyAst.test.ts#L651
AssertionError: expected 'const part001 = startSketchOn(\'-XZ\'…' to contain 'tangentialArcTo([3.14 + 0, 13.14], fa…' - Expected + Received - tangentialArcTo([3.14 + 0, 13.14], false, %) + const part001 = startSketchOn('-XZ') + |> startProfileAt([0, 0], %) + |> line([3 + 0, 4 + 0], %) + |> angledLine({ angle: 3 + 0, length: 3.14 + 0 }, %) + |> lineTo([6.14 + 0, 3.14 + 0], %) + |> xLineTo(8 + 0, %) + |> yLineTo(5 + 0, %) + |> yLine(3.14 + 0, %, $a) + |> xLine(3.14 + 0, %) + |> angledLineOfXLength({ angle: 3 + 0, length: 3.14 + 0 }, %) + |> angledLineOfYLength({ angle: 30 + 0, length: 3 + 0 }, %) + |> angledLineToX({ angle: 12.14 + 0, to: 12 + 0 }, %) + |> angledLineToY({ angle: 30 + 0, to: 10.14 + 0 }, %) + |> angledLineThatIntersects({ + angle: 3.14 + 0, + intersectTag: a, + offset: 0 + 0 + }, %) + |> tangentialArcTo([3.14 + 0, 13.14], %, %) + ❯ src/lang/modifyAst.test.ts:651:26
src/lang/modifyAst/addFillet.test.ts > Testing addFillet > should add a fillet to a specific segment after extrusion, clean: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 5710 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ runFilletTest src/lang/modifyAst/addFillet.test.ts:264:19 ❯ src/lang/modifyAst/addFillet.test.ts:303:11
src/lang/modifyAst/addFillet.test.ts > Testing addFillet > should add a fillet to a specific segment after extrusion with existing tag in any other line: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 5787 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ runFilletTest src/lang/modifyAst/addFillet.test.ts:264:19 ❯ src/lang/modifyAst/addFillet.test.ts:346:11
src/lang/modifyAst/addFillet.test.ts > Testing addFillet > should add a fillet to a specific segment after extrusion with existing tag in that exact line: src/lang/modifyAst/addFillet.test.ts#L266
AssertionError: expected 'const sketch001 = startSketchOn(\'XZ\…' to contain 'const sketch001 = startSketchOn(\'XZ\…' - Expected + Received const sketch001 = startSketchOn('XZ') |> startProfileAt([2.16, 49.67], %) |> line([101.49, 139.93], %) |> line([60.04, -55.72], %) |> line([1.29, -115.74], %) - |> line([-87.24, -47.08], %, $seg03) + |> line([-87.24, -47.08], %, $seg03, $seg01) |> tangentialArcTo([56.15, -94.58], %) |> tangentialArcTo([14.68, -104.52], %) |> lineTo([profileStartX(%), profileStartY(%)], %) |> close(%) const extrude001 = extrude(50, sketch001) - |> fillet({ radius: 5, tags: [seg03] }, %) + |> fillet({ radius: 5, tags: [seg01] }, %) + ❯ runFilletTest src/lang/modifyAst/addFillet.test.ts:266:19 ❯ src/lang/modifyAst/addFillet.test.ts:389:11
src/lang/modifyAst/addFillet.test.ts > Testing addFillet > should add another fillet after the existing fillet: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 5785 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ runFilletTest src/lang/modifyAst/addFillet.test.ts:264:19 ❯ src/lang/modifyAst/addFillet.test.ts:432:11
src/lang/modifyAst/addFillet.test.ts > Testing isTagUsedInFillet > should correctly identify getOppositeEdge and baseEdge edges: src/lang/modifyAst/addFillet.test.ts#L476
AssertionError: expected [] to deeply equal [ 'getOppositeEdge', 'baseEdge' ] - Expected + Received - Array [ - "getOppositeEdge", - "baseEdge", - ] + Array [] ❯ src/lang/modifyAst/addFillet.test.ts:476:19
src/lang/modifyAst/addFillet.test.ts > Testing isTagUsedInFillet > should correctly identify getPreviousAdjacentEdge edges: src/lang/modifyAst/addFillet.test.ts#L495
AssertionError: expected [] to deeply equal [ 'getPreviousAdjacentEdge' ] - Expected + Received - Array [ - "getPreviousAdjacentEdge", - ] + Array [] ❯ src/lang/modifyAst/addFillet.test.ts:495:19
src/lang/std/sketch.test.ts > testing addTagForSketchOnFace > needs to be in it: src/wasm-lib/pkg/wasm_lib.js#L1076
Error: invalid type: null, expected internally tagged enum Expr at line 1 column 2558 ❯ imports.wbg.__wbindgen_error_new src/wasm-lib/pkg/wasm_lib.js:1076:21 ❯ null.<anonymous> wasm:/wasm/029c7356:1:8387040 ❯ null.<anonymous> wasm:/wasm/029c7356:1:5240323 ❯ Module.recast_wasm src/wasm-lib/pkg/wasm_lib.js:401:14 ❯ Module.recast src/lang/wasm.ts:429:10 ❯ src/lang/std/sketch.test.ts:234:12
check-typos
The `python-version` input is not set. The version of Python currently in `PATH` will be used.