Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test: Basic sketch › code pane open at start #3188

Merged

Conversation

ryanrosello-og
Copy link
Contributor

Fix the following frequent failure:

  1) [Google Chrome] › flow-tests.spec.ts:220:7 › Basic sketch › code pane open at start ───────────

    Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected)

    Locator: locator('.cm-content')
    - Expected string  - 3
    + Received string  + 1

    - const sketch001 = startSketchOn('XZ')
    -   |> startProfileAt([7.19, -9.7], %)
    + const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)
    -   |> line([7.25, 0], %)
    Call log:
      - expect.toHaveText with timeout 5000ms
      - waiting for locator('.cm-content')
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"
      -   locator resolved to <div translate="no" role="textbox" autocorrect="off" spellcheck="false" data-language="klc" autocapitalize="off" aria-multiline="true" contenteditable="true" aria-autocomplete="list" class="cm-content cm-lineWrapping">…</div>
      -   unexpected value "const sketch001 = startSketchOn('XZ')  |> startProfileAt([7.19, -9.7], %)"


      149 |   if (openPanes.includes('code')) {
      150 |     await expect(u.codeLocator)
    > 151 |       .toHaveText(`const sketch001 = startSketchOn('XZ')
          |        ^
      152 |   |> startProfileAt(${commonPoints.startAt}, %)
      153 |   |> line([${commonPoints.num1}, 0], %)`)
      154 |   } else {

        at doBasicSketch (/home/runner/work/modeling-app/modeling-app/e2e/playwright/flow-tests.spec.ts:151:8)
        at /home/runner/work/modeling-app/modeling-app/e2e/playwright/flow-tests.spec.ts:221:5

https://github.com/KittyCAD/modeling-app/actions/runs/10160942705/job/28098385549?pr=3102

Chrome now passing 100% (x100 repeats)
2024-07-30_21-13-51

Note: on safari 1 test out of 100 failed for a completely different issue

https://github.com/KittyCAD/modeling-app/actions/runs/10160435043/job/28096820121

Copy link

qa-wolf bot commented Jul 30, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 7, 2024 10:09am

@ryanrosello-og ryanrosello-og marked this pull request as ready for review August 7, 2024 10:20
@ryanrosello-og ryanrosello-og merged commit 8d54fec into main Aug 7, 2024
21 checks passed
@ryanrosello-og ryanrosello-og deleted the ryanrosello-og/fix-test-basic-sketch-code-open-at-start branch August 7, 2024 11:11
@franknoirot franknoirot mentioned this pull request Aug 7, 2024
@Irev-Dev Irev-Dev mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant