Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut release v0.24.10 #3314

Closed
wants to merge 1 commit into from
Closed

Cut release v0.24.10 #3314

wants to merge 1 commit into from

Conversation

franknoirot
Copy link
Collaborator

What's Changed

Full Changelog: v0.24.9...v0.24.10

Copy link

qa-wolf bot commented Aug 7, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 7, 2024 3:19pm

@franknoirot
Copy link
Collaborator Author

@Irev-Dev after some discussion with @lf94 we determined that there was a missing implementation for unpausing the stream when the engine connection was still alive but paused (such as when switching projects), so your fix was necessary and correct. I believe my testing was faulty and held up the release.

@franknoirot
Copy link
Collaborator Author

There is a smoke test failure in Windows, where on first project to be opened the stream will fail to initialize. Further up in the console logs this error appears:

file/C%3A%5CUsers%5C…ct-003%5Cmain.kcl:1  Uncaught (in promise) {"kind":"engine","sourceRanges":[[0,0]],"msg":"Failed to wait for promise from engine: JsValue(\"no connection to send on\")"}

and a fair bit later an "uncaught promise" exception will appear, referring to the same 'no connection to send on'

Video

Screenshare.-.2024-08-07.11_41_52.AM-compressed.mp4

@franknoirot franknoirot closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant