Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates for Swift 4.2 to resolve compilation warnings. Specifically:
Package.swift
to Swift 4.2 format, and renames thePackage@Swift-4.x.swift
->Package@swift-4.x.swift
(SPM otherwise does not pick these up),.swift-version
to 4.2 and adjusts.travis.yml
accordingly,module.modulemap
andshim.h
files from OpenSSL into a new target in this package,errToString(ptr: UnsafeMutablePointer<Int8>?) -> String
helper to avoid string interpolation warnings with optionals.Motivation and Context
Resolves compiler warnings relating to the use of system packages with Swift 4.2.
(see: https://github.com/apple/swift-evolution/blob/master/proposals/0208-package-manager-system-library-targets.md)
Also resolves warnings due to string interpolation of UnsafeMutablePointer? in several error logging messages, which I suspect is related to the rework of implicitly unwrapped optionals: https://github.com/apple/swift-evolution/blob/master/proposals/0054-abolish-iuo.md
How Has This Been Tested?
Checklist: