Rename OpenSSL system library target #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to avoid naming clash with other dependencies that also declare an OpenSSL system library target
This was referenced Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames the
OpenSSLsystem library target toOpenSSLLocal1to avoid a name clash with other packages that also declare an OpenSSL system library target (for example, akitura initproject that depends on both BlueSSLService and BlueCryptor).Motivation and Context
#57 introduced a Swift 4.2 system library target for OpenSSL to replace the external repo. Unfortunately it seems that if multiple packages contain a system library target with the same name, this is considered a name clash and the project fails to compile.
I'm not sure that this is the expected behaviour, but it breaks a
kitura initproject with Swift 4.2 on Linux now that Kitura/BlueCryptor#46 has been tagged.I'll continue to investigate whether we're using system library targets correctly, but in the meantime this workaround resolves the immediate problem.
How Has This Been Tested?
Checklist: