Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename OpenSSL system library target #59

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Rename OpenSSL system library target #59

merged 1 commit into from
Oct 1, 2018

Conversation

djones6
Copy link
Contributor

@djones6 djones6 commented Oct 1, 2018

Description

Renames the OpenSSL system library target to OpenSSLLocal1 to avoid a name clash with other packages that also declare an OpenSSL system library target (for example, a kitura init project that depends on both BlueSSLService and BlueCryptor).

Motivation and Context

#57 introduced a Swift 4.2 system library target for OpenSSL to replace the external repo. Unfortunately it seems that if multiple packages contain a system library target with the same name, this is considered a name clash and the project fails to compile.

I'm not sure that this is the expected behaviour, but it breaks a kitura init project with Swift 4.2 on Linux now that Kitura/BlueCryptor#46 has been tagged.

I'll continue to investigate whether we're using system library targets correctly, but in the meantime this workaround resolves the immediate problem.

How Has This Been Tested?

Checklist:

  • I have submitted a CLA form
  • If applicable, I have updated the documentation accordingly.
  • If applicable, I have added tests to cover my changes.

...to avoid naming clash with other dependencies that also declare an OpenSSL system library target
Copy link
Contributor

@ianpartridge ianpartridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants