-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Scoop support #402
Update Scoop support #402
Conversation
Thank you for the PR! I'll review it in detail and merge when I get the chance.
InstallSource should be a path, so using value of |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks to be working correctly, I only noticed one small issue.
Source
could be$env:SCOOP\buckets\$($bucket)\bucket
, though it's a bit strange if file manager don't scroll to the specific JSON file, since there isn't such property asInstallerName
.
InstallSource can be left empty in this case. RatingId stays the same. In that case the PR looks good to merge after you comment on this suggestion (or apply it as it is).
Also, what do you think about #388? --purge
could be added to all Scoop uninstall commands.
Co-authored-by: Marcin Szeniak <14913904+Klocman@users.noreply.github.com>
This is fine since opening the source JSON file doesn't seems helpful in most cases.
I'd say "persist" should be deleted only when explicitly opted in. Also the persist are quite easy to locate, so maybe just add it to clean-up candidates. |
Ahh, I notice that there might be a typo/misnaming. ( |
It doesn't really matter, in this context it means the same thing. |
Closes #401
DateTimeOffset
converter for Windows PowerShell compatibilityInstallDate
viaUpdated
SetInstallSource
viaSource
SetRatingId
viaSource
string[]
converter forbin
andenv_add_path
AboutUrl
viahomepage
SortedExecutables
viashortcuts
,bin
, andenv_add_path
architecture
awarenessIconBitmap
viashortcuts
with explicit ico fileJsonSerializerContext
support for accelerating JSON parsing