Added duration support to the Merten Roller Shutter drive #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
May 17, 2022
devices/schneider_electric.js
Outdated
| meta: {coverInverted: true}, | ||
| configure: async (device, coordinatorEndpoint, logger) => { | ||
| const endpoint = device.getEndpoint(1) || device.getEndpoint(5); | ||
| const endpoint = device.getEndpoint(5); |
There was a problem hiding this comment.
The duration setting was missing in my original implementation.
When I added it after receiving a Hint, I also realized, that endpoint 1 is not needed for the roller shutter function.
It is only used, when the controller is attached to a light switch insert.
I removed it from my external Converter and did not notice anything missing.
Best regards
There was a problem hiding this comment.
It was added due to Koenkk/zigbee2mqtt#5561 so I believe it should stay
There was a problem hiding this comment.
I have just put it back in - will not hurt anyway.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the function to support setting the duration of the Merten Roller Shutter driver following the request on this post
Tested it and it is working for me (function was also already implemented for the
PUCK/SHUTTER/1device.