Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added duration support to the Merten Roller Shutter drive #4253

Merged
merged 6 commits into from
May 20, 2022
Merged

Added duration support to the Merten Roller Shutter drive #4253

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a526a6d
added duration setting
May 16, 2022
9c2622a
Merge branch 'master' of https://github.com/Koenkk/zigbee-herdsman-co…
May 16, 2022
f03868c
fixed bug
May 16, 2022
fce3225
fixed lint errors
May 16, 2022
08ee364
fixed format lint
May 16, 2022
179917e
added endpoint(1) again
May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions devices/schneider_electric.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,14 @@ module.exports = [
zigbeeModel: ['1GANG/SHUTTER/1'],
model: 'MEG5113-0300/MEG5165-0000',
vendor: 'Schneider Electric',
description: 'Merten PlusLink Shutter insert with Merten Wiser System M Push Button',
description: 'Merten MEG5165 PlusLink Shutter insert with Merten Wiser System M Push Button (1fold)',
fromZigbee: [fz.cover_position_tilt, fz.command_cover_close, fz.command_cover_open, fz.command_cover_stop],
toZigbee: [tz.cover_position_tilt, tz.cover_state],
exposes: [e.cover_position()],
toZigbee: [tz.cover_position_tilt, tz.cover_state, tzLocal.lift_duration],
exposes: [e.cover_position(), exposes.numeric('lift_duration', ea.STATE_SET).withUnit('seconds')
.withValueMin(0).withValueMax(300).withDescription('Duration of lift')],
meta: {coverInverted: true},
configure: async (device, coordinatorEndpoint, logger) => {
const endpoint = device.getEndpoint(1) || device.getEndpoint(5);
const endpoint = device.getEndpoint(5);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duration setting was missing in my original implementation.
When I added it after receiving a Hint, I also realized, that endpoint 1 is not needed for the roller shutter function.
It is only used, when the controller is attached to a light switch insert.
I removed it from my external Converter and did not notice anything missing.

Best regards

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added due to Koenkk/zigbee2mqtt#5561 so I believe it should stay

Copy link
Contributor Author

@7h0mas-R 7h0mas-R May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just put it back in - will not hurt anyway.

await reporting.bind(endpoint, coordinatorEndpoint, ['closuresWindowCovering']);
await reporting.currentPositionLiftPercentage(endpoint);
},
Expand Down