Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FieldBinarySignature which corresponds to Companion field should have companion annotations #157

Closed
dovchinnikov opened this issue Dec 4, 2023 · 0 comments · Fixed by #162
Closed

FieldBinarySignature which corresponds to Companion field should have companion annotations #157

dovchinnikov opened this issue Dec 4, 2023 · 0 comments · Fixed by #162

Comments

@dovchinnikov
Copy link

In particular, a companion class, which is annotated with non-public marker, is excluded from the API, but the Companion field is still present.

Additionally, in IJ we analyze the presence of @ApiStatus.Experimental, which is also absent from FieldBinarySignature of Companion field.
fzhinkin added a commit that referenced this issue Dec 15, 2023
@fzhinkin
Add all Companion class' annotations to corresponding Companion field.
380db28 
Fixes #157
@fzhinkin fzhinkin mentioned this issue Dec 15, 2023
Merged
fzhinkin added a commit that referenced this issue Jan 16, 2024
@fzhinkin
Add all Companion class' annotations to corresponding Companion field.
c1133f0 
Fixes #157
fzhinkin added a commit that referenced this issue Jan 18, 2024
@fzhinkin
Add all Companion class annotations to the corresponding Companion fi…
066e01e 
…eld. (#162)

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes #157
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Oct 28, 2024
@fzhinkin @shanshin
[ABI Validation] Add all Companion class annotations to the correspon…
40d673f 
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 3, 2024
@fzhinkin @shanshin
[ABI Validation] Add all Companion class annotations to the correspon…
247ca5a 
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 13, 2024
@fzhinkin @shanshin
[ABI Validation] Add all Companion class annotations to the correspon…
9bb0e4d 
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this issue Dec 23, 2024
@fzhinkin @shanshin
[ABI Validation] Add all Companion class annotations to the correspon…
0510243 
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162

Moved from Kotlin/binary-compatibility-validator@066e01e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dovchinnikov