Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Companion class' annotations to corresponding Companion field. #162

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

fzhinkin
Copy link
Collaborator

Fixes #157

@fzhinkin fzhinkin marked this pull request as ready for review December 15, 2023 12:54
@fzhinkin fzhinkin requested review from qwwdfsad and ilya-g December 15, 2023 12:54
src/main/kotlin/api/KotlinSignaturesLoading.kt Outdated Show resolved Hide resolved
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fzhinkin fzhinkin merged commit 066e01e into master Jan 18, 2024
1 check passed
@fzhinkin fzhinkin deleted the 157-enrich-companion-fld-with-class-annotations branch January 18, 2024 16:30
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Oct 28, 2024
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 3, 2024
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 13, 2024
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162
shanshin pushed a commit to JetBrains/kotlin that referenced this pull request Dec 23, 2024
…ding Companion field.

* Add all Companion class annotations to the corresponding Companion field.
* Extract logic for building field and method signatures to separate methods

Fixes Kotlin/binary-compatibility-validator#157


Pull request Kotlin/binary-compatibility-validator#162

Moved from Kotlin/binary-compatibility-validator@066e01e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldBinarySignature which corresponds to Companion field should have companion annotations
2 participants