-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better static tables #519
Better static tables #519
Conversation
…nd flattened ColGroups for static tables in ipynb files
Okay, outside of Github, this static rendering works great, however, Github cannot render anything even smelling interactive. I tried CSS tricks, |
…r-static-tables # Conflicts: # examples/notebooks/github/github.ipynb
Added ! to DataColumnArithmetics
Add readArrowReader method to allow loading a dataframe from an ArrowReader
This was already updated but reverted somehow. Fixes unexpected character bug on windows machines.
Update simple-git version to 2.0.3
…nstead of column content as a key for `associateBy`.
Fix performance problem in `rename` implementation
* Ported the fix for JDBC integration from the 0.12.1 branch * Removed unused imports * Linting fix * Update README and improve documentation clarity
Ok, i think i understand what's going on in that matrix creation. Looks good! Few suggestions: move implementation to staticHtml.kt, there's now a lot of specific things not related to regular HTML. Second, have you checked escaping? |
@koperagen Thanks! I'll move it to another file. Edit: Okay rebasing on master caused all these extra commits to appear... fun |
…nd flattened ColGroups for static tables in ipynb files
Based upon #513, this fix adds better static tables with uncollapsed column groups as well as interactive frame columns using
<details>
(without JS and optional CSS).This allows ipynb notebook files to be viewed by simple renderers that don't allow iFrames or JS to be run (such as GitHub). Note that Github strips out the CSS and
<details>
tags and displays the nested DataFrames in full, so I made sure the limits for nested dataframes were reasonable.This means: We adhere to the given
rowsLimit
andnestedRowsLimit
(20 and 5 by default respectively) for the top-level and we halve thenestedRowsLimit
(rounding up) for each deeper nested DF.I also updated all notebooks except for the json one (it's too large for GH now)