Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReceiveChannel.broadcast shall start lazy coroutine when closed #1717

Merged
merged 4 commits into from
Mar 16, 2020
Merged

ReceiveChannel.broadcast shall start lazy coroutine when closed #1717

merged 4 commits into from
Mar 16, 2020

Conversation

elizarov
Copy link
Contributor

Fixes #1713

@elizarov elizarov changed the title ReceiveChannel.broadcast shall properly consume source channel when closed ReceiveChannel.broadcast shall start lazy coroutine when closed Dec 25, 2019
@elizarov
Copy link
Contributor Author

I've totally reworked and force-pushed this update.

  • Documentation on broadcast operators is added that explains that the resulting BroadcastChannel shall be cancelled if it is not needed anymore.
  • More tests added for various broadcast cancel/close cases.
  • The only functional change is that closing a broadcast channel for lazy coroutine shall start the corresponding coroutine to give it a chance to promptly fail.
  • Mark broadcast operators as obsolete. To be replaced with sharing operators on flows (see shareIn and cache operators #1716).

@elizarov elizarov mentioned this pull request Dec 25, 2019
Closed
@qwwdfsad qwwdfsad force-pushed the develop branch 3 times, most recently from 4a49830 to aff8202 Compare March 10, 2020 17:27
@elizarov
ReceiveChannel.broadcast shall start lazy coroutine when closed
b4ccb30 
* Documentation on broadcast operators is added that explains that the resulting BroadcastChannel shall be cancelled if it is not needed anymore.
* More tests added for various broadcast cancel/close cases.
* The only functional change is that closing a broadcast channel for lazy coroutine shall start the corresponding coroutine to give it a chance to promptly fail.
* Mark broadcast operators as obsolete. To be replaced with sharing operators on flows (see #1716).

Fixes #1713
@elizarov
~ Not obsolete until we have replacement
2564dea
@elizarov
~ Also fix the order of events in lazy actor
9ef76cc
@elizarov
~ Don't mark broadcast as obsolete yet
59b4067 
There is no replacement and it would just makes life harder for people.
@qwwdfsad qwwdfsad self-requested a review March 16, 2020 13:38
qwwdfsad
qwwdfsad approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qwwdfsad qwwdfsad merged commit e0a6533 into develop Mar 16, 2020
@qwwdfsad qwwdfsad deleted the broadcast-close branch March 16, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizarov @qwwdfsad